metrics icon indicating copy to clipboard operation
metrics copied to clipboard

fix(plugins/notable): possible issues

Open lowlighter opened this issue 3 years ago • 0 comments

Discussed in https://github.com/lowlighter/metrics/discussions/1148

Originally posted by jayvdb July 22, 2022 For the notable plugin, I set debug: true and plugin_notable_types: commit, issue, pull_request, and obviously have indepth enabled, and now I am seeing quite a few of the following in the log

metrics/compute/jayvdb/plugins > notable > indepth > successfully processed ansible/ansible-lint
TypeError: contributions.filter is not a function
      at Object.default [as notable] (file:///metrics/source/plugins/notable/index.mjs:83:41)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async file:///metrics/source/plugins/core/index.mjs:67:30
      at async Promise.all (index 0)
      at async metrics (file:///metrics/source/app/metrics/index.mjs:64:22)
      at async retry.retries.retries (file:///metrics/source/app/action/index.mjs:398:34)
      at async retry (file:///metrics/source/app/action/index.mjs:57:22)
      at async file:///metrics/source/app/action/index.mjs:397:20
  metrics/compute/jayvdb/plugins > notable > indepth > failed to compute for pdm-project/pdm
  metrics/compute/jayvdb/plugins > notable > indepth > successfully processed TheLartians/ModernCppStarter

Run: https://github.com/jayvdb/jayvdb/runs/7468279468?check_suite_focus=true

I don't have any commits in that repo, but I did create an issue: https://github.com/pdm-project/pdm/issues/created_by/jayvdb

pdm now appears in my svg https://github.com/jayvdb/jayvdb/commit/01ec97176e18086d5cd4bd0fc70d35b065ea5698 without any of the numerical scores inside its circle.

So I am guessing that plugin_notable_types of issue & pull_request are incompatible with indepth at the moment, unless there was a commit also in the repo.

But the problem is a bit more nuanced than that, as I only have a rejected issue in https://github.com/TheLartians/ModernCppStarter/issues/131, and only an unmerged closed PR in https://github.com/ansible/ansible-lint/pull/2196 - both repos that were "successfully processed".

lowlighter avatar Jul 25 '22 23:07 lowlighter