Karl Lorey

Results 42 comments of Karl Lorey

What does "doesn't work" mean in that context? I think that it's impossible to get it right with one sample (and esp. for two slightly different pages). I would most...

So regarding spiegel online, this was quite some work as articles have different layouts. Took me some major performance tweaks to get it running in a sensible amount of time...

Fixed the authors issue, now takes around 30s on my machine. Formatting by me: ``` INFO:root:found DictScraper (scraper_per_key={ 'published': , 'subtitle': , 'title': , self.extractor=>, 'teaser': , 'authors': }) #...

There's some weird whitespace causing issues. But it works if you change the price to a proper price in dot notation (which is hidden in the html): ```python ARTICLES =...

I think generally this needs to be fixed by #15

Maybe related to #15

Code can be included within .rst, maybe just run the code and include it.

This is still open, currently rules get generated with more complexity, but increasing complexity stops at selectors with two levels, e.g. `.test > .value.target.box`.

Basic end-to-end tests added.

What specifically do you mean? Can you give some examples, please?