touchstone icon indicating copy to clipboard operation
touchstone copied to clipboard

Proactively go for feedback

Open lorenzwalthert opened this issue 3 years ago • 13 comments
trafficstars

Identify repos that could benefit from {touchstone} and help them setting it up:

  • tidyverse/tibble
  • R data table seems to be looking for a continuous benchmarking tool and has not yet found one.
  • r-lib/vctrs?
  • https://github.com/dirkschumacher/ompr

lorenzwalthert avatar Jan 14 '22 17:01 lorenzwalthert

oh thats' a good idea!

assignUser avatar Jan 14 '22 17:01 assignUser

data.table has on open issue, should I go ahead and pitch {touchstone}? Or wait till after #95 is merged?

assignUser avatar Jan 14 '22 17:01 assignUser

Let's wait for #95. And then tell them we'll contribute it to ropensci and submit to CRAN 🥳

lorenzwalthert avatar Jan 14 '22 17:01 lorenzwalthert

FWIW --- I've been lurking on here awaiting your first CRAN release after which we'll probably try out using {touchstone} with {posterior} https://github.com/stan-dev/posterior/issues/159. We definitely have need for it! :)

mjskay avatar Jan 14 '22 22:01 mjskay

Hey @mjskay thanks for dropping stealth 😄

As you probably have seen we are getting ready to submit to ropensci and afterwards CRAN, so our API should be pretty much stable by now. I would greatly appreciate any feedback on usability and function from a third party (currently @lorenzwalthert and I are the only users of the package afaik) prior to our CRAN release.

Maybe you can give it a try once #95 is merged?

assignUser avatar Jan 14 '22 22:01 assignUser

Thanks, it's good to know your intended timeline. If I have time (busy quarter atm) I'll give it a try after #95 is merged and let you know if I run into anything.

mjskay avatar Jan 15 '22 00:01 mjskay

The maintainers of {greta} also seem to be keen to try this out (https://github.com/greta-dev/greta/issues/365).

lorenzwalthert avatar Jan 15 '22 06:01 lorenzwalthert

@lorenzwalthert I think we are now ready to go "Klinkenputzen", don't you think?

assignUser avatar Jan 17 '22 20:01 assignUser

I agree yes.

lorenzwalthert avatar Jan 19 '22 07:01 lorenzwalthert

https://github.com/dirkschumacher/ompr could be a candidate, also in the light of https://twitter.com/dirk_sch/status/1487039412886192128

lorenzwalthert avatar Jan 28 '22 16:01 lorenzwalthert

https://github.com/greta-dev/greta/runs/6824667937?check_suite_focus=true seems to fail...

lorenzwalthert avatar Jun 21 '22 18:06 lorenzwalthert

@lorenzwalthert Ok looked into it, that is a side effect of the new optional trigger. Even if the workflow is skipped when an issue comment is created that does not contain /benchmark it still triggers the comment workflow that then has no idea whats happening and fails :D I'll open an issue and implement a fix

assignUser avatar Jul 21 '22 18:07 assignUser

Thanks for the quick response.

lorenzwalthert avatar Jul 21 '22 18:07 lorenzwalthert