sdk-codegen icon indicating copy to clipboard operation
sdk-codegen copied to clipboard

Published 20 hours ago • verified publisher icon looker-open-source

docs: looker oauth implementation example

Open josephaxisa opened this issue 3 years ago • 3 comments

josephaxisa avatar Feb 17 '22 19:02 josephaxisa

Nice! I don't feel qualified to review the react but I do feel like an examples/looker-oauth/README.md would be good to guide setup

+1 to this!!!

bryans99 avatar Feb 18 '22 18:02 bryans99

for sure, it's on my todo list for this PR.

josephaxisa avatar Feb 18 '22 18:02 josephaxisa

This PR is still very much a draft. I will polish it a bit more tomorrow, please hold off on re-reviewing.

TODOs:

  • [ ] readme
  • [ ] use versions url to get api server url
  • [ ] provide way to clear local storage
  • [ ] better error handling

josephaxisa avatar Feb 21 '22 17:02 josephaxisa