sdk-codegen icon indicating copy to clipboard operation
sdk-codegen copied to clipboard

docs: Simple example of creating a dashboard filter and applying it t…

Open drstrangelooker opened this issue 3 years ago • 1 comments

…o dashboard elements (#818)

  • Pushing new_dashboard_filter to remote

  • Adding example to create_dashboard_filter, fixes 816

  • Rename dashboard_filter file

  • add new line at end of file

  • Fixing new line at end of file 🤦🏼‍♂️

  • Condensing loops

  • Consolidating loops, adding check for matching model and explore

  • Removing unnecessary loop

Co-authored-by: Kevin Dunn [email protected]

Copy of https://github.com/looker-open-source/sdk-codegen/pull/818

drstrangelooker avatar Feb 15 '22 21:02 drstrangelooker

For the future, we should have contributors point their PRs to main and merge their PRs into main. Or else this leaves the change owner unaware of their changes going into main and clutters our commit history with co-authors.

jeremytchang avatar Feb 18 '22 19:02 jeremytchang