sdk-codegen icon indicating copy to clipboard operation
sdk-codegen copied to clipboard

feat(APIError): New Python error class giving access to API response

Open ob1-dev opened this issue 4 years ago • 2 comments

This change introduces a new APIError class (inheriting from SDKError) which takes one argument of the api_response which should be the JSON payload from the Looker endpoint.

This gets loaded by the class and made accessible as the APIError.api_response property.

The idea is to give simpler access to the type of error that was received from the endpoint in order to take different actions.

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [X] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Appropriate docs were updated (if necessary)

Fixes #723 🦕

ob1-dev avatar Jun 29 '21 21:06 ob1-dev

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 29 '21 21:06 google-cla[bot]

@googlebot I signed it!

ob1-dev avatar Jun 29 '21 21:06 ob1-dev

Thanks for your submission. We've implemented the functionality in a similar PR. #1170

jkaster avatar Sep 01 '22 01:09 jkaster

There wasn't anything wrong with your PR, but this was something we already had in process. Thanks again for your contribution. You definitely saw the need!

jkaster avatar Sep 01 '22 01:09 jkaster