sdk-codegen icon indicating copy to clipboard operation
sdk-codegen copied to clipboard

WIP: filter sharing with custom reconciliation hooks

Open patnir41 opened this issue 3 years ago • 3 comments

Changes to review:

  • syncHooks.ts creates the custom reconciliation hooks for the APIExplorer and TagScene pages (note I only have this functional for MethodTagScene at the moment, not TypeTagScene)
  • APIExplorer.tsx calls useGlobalSync, which handles the reconciliation of the SDK parameter
  • MethodTagScene.tsx calls useTagSceneSync, which handles its specific reconciliation with the verb parameter

Feel free to pick at the naming/organization, I know it is not perfect since I just wanted to ensure I followed the right direction with this approach.

Questions:

  1. Is this the best way to use the return from useSync hooks? Need to clarify when, or if, we need to ever render an empty component, and what to do with the return value from this hook?

  2. How to go about the "smarter" navigation and remove unnecessary parameters without bloated code -> should I reuse navigate, but have specific functions in the hook that will first remove / nullify certain query parameters before calling it? E.g. navigateFromDiff will take whatever query parameters, but in the function will nullify every DiffScene-specific parameters before calling navigate within.

  3. Should I proceed with changing the Link to a Span with link-like behavior so we can call navigate? Ctrl+F and search TODO, where I am explicitly removing the filter parameter before it opens a new method to see where this pertains. I am struggling a little on how I should get this to behave properly and not make the code confusing.

patnir41 avatar Aug 10 '22 22:08 patnir41

APIX Tests

0 files   -     1  0 suites   - 82   0s :stopwatch: - 6m 6s 0 tests  - 357  0 :heavy_check_mark:  - 344  0 :zzz:  - 13  0 :x: ±0  0 runs   - 373  0 :heavy_check_mark:  - 360  0 :zzz:  - 13  0 :x: ±0 

Results for commit 7c04e611. ± Comparison against base commit ae59b956.

This pull request removes 357 tests.
 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
ApiSpecSelector it lists all available specs ‑ ApiSpecSelector it lists all available specs
ApiSpecSelector requests selected spec ‑ ApiSpecSelector requests selected spec
ApiSpecSelector the base spec is selected by default ‑ ApiSpecSelector the base spec is selected by default
Banner renders with button that opens api 4.0 dev portal link in new page ‑ Banner renders with button that opens api 4.0 dev portal link in new page
Banner sets local storage value and unrenders on close button click ‑ Banner sets local storage value and unrenders on close button click
BrowserAdaptor copies location href to clipboard ‑ BrowserAdaptor copies location href to clipboard
BrowserAdaptor returns correct font overrides ‑ BrowserAdaptor returns correct font overrides
CodeCopy displays code and clipboard UI ‑ CodeCopy displays code and clipboard UI
…

github-actions[bot] avatar Aug 10 '22 22:08 github-actions[bot]

APIX Tests

0 files   -     1  0 suites   - 82   0s :stopwatch: - 6m 6s 0 tests  - 357  0 :heavy_check_mark:  - 344  0 :zzz:  - 13  0 :x: ±0  0 runs   - 373  0 :heavy_check_mark:  - 360  0 :zzz:  - 13  0 :x: ±0 

Results for commit 863bf476. ± Comparison against base commit ae59b956.

This pull request removes 357 tests.
 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
ApiSpecSelector it lists all available specs ‑ ApiSpecSelector it lists all available specs
ApiSpecSelector requests selected spec ‑ ApiSpecSelector requests selected spec
ApiSpecSelector the base spec is selected by default ‑ ApiSpecSelector the base spec is selected by default
Banner renders with button that opens api 4.0 dev portal link in new page ‑ Banner renders with button that opens api 4.0 dev portal link in new page
Banner sets local storage value and unrenders on close button click ‑ Banner sets local storage value and unrenders on close button click
BrowserAdaptor copies location href to clipboard ‑ BrowserAdaptor copies location href to clipboard
BrowserAdaptor returns correct font overrides ‑ BrowserAdaptor returns correct font overrides
CodeCopy displays code and clipboard UI ‑ CodeCopy displays code and clipboard UI
…

github-actions[bot] avatar Aug 10 '22 23:08 github-actions[bot]

APIX Tests

0 files   -     1  0 suites   - 82   0s :stopwatch: - 6m 6s 0 tests  - 357  0 :heavy_check_mark:  - 344  0 :zzz:  - 13  0 :x: ±0  0 runs   - 373  0 :heavy_check_mark:  - 360  0 :zzz:  - 13  0 :x: ±0 

Results for commit 6e3f9ea6. ± Comparison against base commit ae59b956.

This pull request removes 357 tests.
 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
ApiSpecSelector it lists all available specs ‑ ApiSpecSelector it lists all available specs
ApiSpecSelector requests selected spec ‑ ApiSpecSelector requests selected spec
ApiSpecSelector the base spec is selected by default ‑ ApiSpecSelector the base spec is selected by default
Banner renders with button that opens api 4.0 dev portal link in new page ‑ Banner renders with button that opens api 4.0 dev portal link in new page
Banner sets local storage value and unrenders on close button click ‑ Banner sets local storage value and unrenders on close button click
BrowserAdaptor copies location href to clipboard ‑ BrowserAdaptor copies location href to clipboard
BrowserAdaptor returns correct font overrides ‑ BrowserAdaptor returns correct font overrides
CodeCopy displays code and clipboard UI ‑ CodeCopy displays code and clipboard UI
…

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

APIX Tests

    1 files  ±  0    82 suites  ±0   6m 7s :stopwatch: -1s 381 tests +24  368 :heavy_check_mark: +24  13 :zzz: ±0  0 :x: ±0  401 runs  +28  388 :heavy_check_mark: +28  13 :zzz: ±0  0 :x: ±0 

Results for commit 0b09d4f1. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 31 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 11 '22 23:08 github-actions[bot]

APIX Tests

    1 files  ±  0    82 suites  ±0   6m 2s :stopwatch: -4s 381 tests +24  368 :heavy_check_mark: +24  13 :zzz: ±0  0 :x: ±0  401 runs  +28  388 :heavy_check_mark: +28  13 :zzz: ±0  0 :x: ±0 

Results for commit 2d54f376. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 31 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 11 '22 23:08 github-actions[bot]

APIX Tests

    1 files  ±  0    82 suites  ±0   8m 30s :stopwatch: + 2m 24s 381 tests +24  368 :heavy_check_mark: +24  13 :zzz: ±0  0 :x: ±0  401 runs  +28  388 :heavy_check_mark: +28  13 :zzz: ±0  0 :x: ±0 

Results for commit caa189c6. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 31 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 12 '22 16:08 github-actions[bot]

APIX Tests

    1 files  ±  0    83 suites  +1   5m 18s :stopwatch: -48s 383 tests +26  370 :heavy_check_mark: +26  13 :zzz: ±0  0 :x: ±0  403 runs  +30  390 :heavy_check_mark: +30  13 :zzz: ±0  0 :x: ±0 

Results for commit ae47fa01. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 33 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 15 '22 18:08 github-actions[bot]

APIX Tests

    1 files  ±  0    84 suites  +2   6m 4s :stopwatch: -2s 392 tests +35  379 :heavy_check_mark: +35  13 :zzz: ±0  0 :x: ±0  412 runs  +39  399 :heavy_check_mark: +39  13 :zzz: ±0  0 :x: ±0 

Results for commit 70ae6e28. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 42 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 15 '22 22:08 github-actions[bot]

APIX Tests

    1 files  ±  0    84 suites  +2   6m 8s :stopwatch: +2s 392 tests +35  379 :heavy_check_mark: +35  13 :zzz: ±0  0 :x: ±0  412 runs  +39  399 :heavy_check_mark: +39  13 :zzz: ±0  0 :x: ±0 

Results for commit 376e21b3. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 42 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 15 '22 23:08 github-actions[bot]

APIX Tests

    1 files  ±  0    84 suites  +2   5m 22s :stopwatch: -44s 392 tests +35  379 :heavy_check_mark: +35  13 :zzz: ±0  0 :x: ±0  412 runs  +39  399 :heavy_check_mark: +39  13 :zzz: ±0  0 :x: ±0 

Results for commit e1e4c0a3. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 42 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 16 '22 23:08 github-actions[bot]

APIX Tests

0 files   -     1  0 suites   - 82   0s :stopwatch: - 6m 6s 0 tests  - 357  0 :heavy_check_mark:  - 344  0 :zzz:  - 13  0 :x: ±0  0 runs   - 373  0 :heavy_check_mark:  - 360  0 :zzz:  - 13  0 :x: ±0 

Results for commit f44e2f6b. ± Comparison against base commit ae59b956.

This pull request removes 357 tests.
 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
ApiSpecSelector it lists all available specs ‑ ApiSpecSelector it lists all available specs
ApiSpecSelector requests selected spec ‑ ApiSpecSelector requests selected spec
ApiSpecSelector the base spec is selected by default ‑ ApiSpecSelector the base spec is selected by default
Banner renders with button that opens api 4.0 dev portal link in new page ‑ Banner renders with button that opens api 4.0 dev portal link in new page
Banner sets local storage value and unrenders on close button click ‑ Banner sets local storage value and unrenders on close button click
BrowserAdaptor copies location href to clipboard ‑ BrowserAdaptor copies location href to clipboard
BrowserAdaptor returns correct font overrides ‑ BrowserAdaptor returns correct font overrides
CodeCopy displays code and clipboard UI ‑ CodeCopy displays code and clipboard UI
…

github-actions[bot] avatar Aug 17 '22 19:08 github-actions[bot]

APIX Tests

    1 files  ±  0    84 suites  +2   6m 7s :stopwatch: -1s 392 tests +35  379 :heavy_check_mark: +35  13 :zzz: ±0  0 :x: ±0  412 runs  +39  399 :heavy_check_mark: +39  13 :zzz: ±0  0 :x: ±0 

Results for commit fd213b35. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 42 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 17 '22 20:08 github-actions[bot]

APIX Tests

    1 files  ±  0    84 suites  +2   6m 8s :stopwatch: +2s 392 tests +35  379 :heavy_check_mark: +35  13 :zzz: ±0  0 :x: ±0  412 runs  +39  399 :heavy_check_mark: +39  13 :zzz: ±0  0 :x: ±0 

Results for commit 6ac60835. ± Comparison against base commit ae59b956.

This pull request removes 7 and adds 42 tests. Note that renamed tests count towards both.
MethodTagScene it filters methods by operation type ‑ MethodTagScene it filters methods by operation type
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate clears existing params when given params are null ‑ Navigate clears existing params when given params are null
Navigate null query params are removed ‑ Navigate null query params are removed
Navigate preserves existing query params when given params are undefined ‑ Navigate preserves existing query params when given params are undefined
Navigate sets query parameters when given a populated query params object ‑ Navigate sets query parameters when given a populated query params object
TypeTagScene it filters methods by operation type ‑ TypeTagScene it filters methods by operation type
MethodTagScene it pushes filter to URL on toggle ‑ MethodTagScene it pushes filter to URL on toggle
Settings selectors selectTagFilter selects ‑ Settings selectors selectTagFilter selects
TypeTagScene it pushes filter to URL on toggle ‑ TypeTagScene it pushes filter to URL on toggle
path utils getSceneType returns correct scene type given location with pathname ‑ path utils getSceneType returns correct scene type given location with pathname
path utils getSceneType returns empty string if there is no scene type ‑ path utils getSceneType returns empty string if there is no scene type
path utils isValidFilter invalidates DELETE when containing extra characters ‑ path utils isValidFilter invalidates DELETE when containing extra characters
path utils isValidFilter invalidates ENUMERATED when containing extra characters ‑ path utils isValidFilter invalidates ENUMERATED when containing extra characters
path utils isValidFilter invalidates GET when containing extra characters ‑ path utils isValidFilter invalidates GET when containing extra characters
path utils isValidFilter invalidates PATCH when containing extra characters ‑ path utils isValidFilter invalidates PATCH when containing extra characters
path utils isValidFilter invalidates POST when containing extra characters ‑ path utils isValidFilter invalidates POST when containing extra characters
…

github-actions[bot] avatar Aug 17 '22 20:08 github-actions[bot]

APIX Tests

    1 files    84 suites   5m 59s :stopwatch: 392 tests 379 :heavy_check_mark: 13 :zzz: 0 :x: 412 runs  399 :heavy_check_mark: 13 :zzz: 0 :x:

Results for commit a1cf3422.

github-actions[bot] avatar Aug 17 '22 21:08 github-actions[bot]

APIX Tests

    1 files    84 suites   6m 27s :stopwatch: 392 tests 379 :heavy_check_mark: 13 :zzz: 0 :x: 412 runs  399 :heavy_check_mark: 13 :zzz: 0 :x:

Results for commit 494ff79d.

github-actions[bot] avatar Aug 17 '22 21:08 github-actions[bot]

APIX Tests

    1 files  ±0    84 suites  ±0   5m 30s :stopwatch: ±0s 392 tests ±0  379 :heavy_check_mark: ±0  13 :zzz: ±0  0 :x: ±0  412 runs  ±0  399 :heavy_check_mark: ±0  13 :zzz: ±0  0 :x: ±0 

Results for commit 135dce3a. ± Comparison against base commit 135dce3a.

github-actions[bot] avatar Aug 17 '22 21:08 github-actions[bot]