actions icon indicating copy to clipboard operation
actions copied to clipboard

Fix /oauth_token route to correctly handle POST

Open bgraves-lo opened this issue 1 month ago • 1 comments

  • Adds fetchTokenState to Hub.ActionRequest to store posted state data if present.
  • Modify GoogleDriveAction to account for this change
  • Add asJson method to ActionToken class to align with ActionResponse

bgraves-lo avatar Oct 30 '25 00:10 bgraves-lo

Summary of Changes

Hello @bgraves-lo, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the /oauth_token route was not correctly handling state data when it was submitted via a POST request. The changes introduce a dedicated property within the ActionRequest object to store this posted state, ensuring that OAuth actions, such as GoogleDriveAction, can properly access and decrypt it. This enhancement improves the reliability of OAuth authentication flows that depend on state parameters being passed in the request body.

Highlights

  • Enhanced OAuth Token Handling: The /oauth_token route now correctly processes state data when it is sent via a POST request, ensuring proper handling of OAuth flows that rely on posted state.
  • ActionRequest Update: A new fetchTokenState property has been added to Hub.ActionRequest to specifically store the posted state data, improving the clarity and robustness of state management.
  • GoogleDriveAction Adaptation: The GoogleDriveAction has been updated to utilize the new fetchTokenState property when decrypting the OAuth state, aligning with the changes in ActionRequest.
  • Improved Type Definitions and Testing: Type definitions for DataWebhookPayload and ActionRequest have been updated to reflect the new state and fetchTokenState properties, respectively. New test cases have also been added to validate the correct parsing of state from request bodies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 30 '25 00:10 gemini-code-assist[bot]