python-tent-client icon indicating copy to clipboard operation
python-tent-client copied to clipboard

Consider using snake case

Open graue opened this issue 12 years ago • 3 comments
trafficstars

While python-tent-client is young, I wonder I could convince you to use snake_case for functions and variable names. For example, hasRegistrationKeys would become has_registration_keys. Class names, including exceptions, would still be camel case.

I think this would be less confusing. After all, Tent itself uses snake case (mac_key, avatar_url, published_at), and so do popular Python libraries likely to be used with python-tent-client: Requests has status_code, Flask has render_template, and so on.

graue avatar Dec 06 '12 08:12 graue

Good idea. I looked up PEP8 and discovered that snake_case is indeed recommended for functions and variable names.

I likely won't get to this until next week. If anyone wants to submit a pull request in the meantime, you should coordinate with @graue who might be making other changes that wouldn't merge well with a big change like this one.

longears avatar Dec 07 '12 19:12 longears

+1

elimisteve avatar Apr 21 '13 22:04 elimisteve

+1

ajvb avatar Apr 22 '13 01:04 ajvb