lona icon indicating copy to clipboard operation
lona copied to clipboard

fix client rendering issues

Open fscherf opened this issue 3 years ago • 1 comments
trafficstars

This PR replaces the old client pre compiler infrastructure with Javascript ES06 imports and, and fixes multiple rendering issues reported by @SmithChart

fscherf avatar Aug 26 '22 18:08 fscherf

Codecov Report

Merging #232 (318312f) into master (754d4e9) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   62.24%   62.13%   -0.12%     
==========================================
  Files          67       66       -1     
  Lines        4818     4772      -46     
  Branches      932      924       -8     
==========================================
- Hits         2999     2965      -34     
+ Misses       1566     1559       -7     
+ Partials      253      248       -5     
Impacted Files Coverage Δ
lona/server.py 67.49% <ø> (+0.10%) :arrow_up:
lona/protocol.py 69.04% <100.00%> (+2.09%) :arrow_up:
lona/static_file_loader.py 79.27% <100.00%> (+1.20%) :arrow_up:
lona/templating.py 83.95% <100.00%> (+2.86%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 26 '22 18:08 codecov-commenter

Fixes the behavior of my reproducer in #231 . Thx

SmithChart avatar Sep 10 '22 12:09 SmithChart

@SmithChart: Thanks for reporting and testing!

fscherf avatar Sep 19 '22 15:09 fscherf