lightbox2 icon indicating copy to clipboard operation
lightbox2 copied to clipboard

Published 20 hours ago • verified publisher icon lokesh

Use SASS for compiling lightbox.css

Open helloilya opened this issue 9 years ago • 6 comments

Added sass preprocessor support (issue #495), added buildsass grunt task (sass/autoprefixer).

helloilya avatar Jan 17 '16 19:01 helloilya

Looks good, let's get it in.

jamesstar89 avatar Jan 18 '16 06:01 jamesstar89

Use a var like $lb-image-path: '../images' !default;. It's not uncommon for people to use lots of @imports in their sass/scss, making the relative pathing confusing/wrong. That's why bootstrap-sass does it.

k-funk avatar Jun 02 '16 23:06 k-funk

Improved styles, fixed a few wrong moments.

helloilya avatar Jun 20 '16 08:06 helloilya

LGTM

k-funk avatar Jun 20 '16 10:06 k-funk

+1

bahiirwa avatar Apr 19 '17 10:04 bahiirwa

This is an old PR that rewrites the CSS with SASS. I wanted to chime in on why it wasn't merged for anyone who comes across it in the future. For this project I've opted to keep the barrier for usage and outside development very low. So this means no precompilers. At one point I had switched to Coffeescript which caused significant confusion for those unfamiliar with it.

Also, at this point, SASS is making way for PostCSS. And with the minimal amount of CSS in the project, it isn't worth it IMHO.

For features like this that aren't on the roadmap I keep the PRs open so they are visible for others who might be interested in utilizing the code.

lokesh avatar Nov 26 '17 03:11 lokesh