LPATHBench icon indicating copy to clipboard operation
LPATHBench copied to clipboard

Published 20 hours ago • verified publisher icon logicchains

Compilation fixes

Open bjourne opened this issue 9 years ago • 3 comments

A few little compiler warnings cleanups and makefile improvements. I also think you should consider changing -O2 to -O3 as that makes the c_fast benchmark much faster when compiled with clang. Clang in general beats gcc on my machine.

bjourne avatar Jun 11 '16 02:06 bjourne

@lgeek, I apologise for not making myself more clear. My intention with this pr was not to invest to much time in your LPathBench project. I just wanted to share the changes I needed to make it work well for me. Feel free to reject this pr, apply it or do whatever you want with it. Sorry, but I don't have either the time or the interest in working more on it.

bjourne avatar Jun 11 '16 15:06 bjourne

@bjourne Sorry if this is wasn't clear, but this is not my project. I just wrote the c-fast implementation and I've only reviewed the patches related to it. It's not up to me what gets merged. I've pointed out the changes which either break things (e.g. the printf one) or which change behavior (the flags).

lgeek avatar Jun 11 '16 16:06 lgeek

I think "%"PRIu64 is the right way to express the format. Though it appears that %lu does not break anything on 32bit platforms.

bjourne avatar Jun 11 '16 17:06 bjourne