devpod icon indicating copy to clipboard operation
devpod copied to clipboard

Add more colors for failed/successfuls steps on devpod terminal

Open vesperrin opened this issue 2 years ago • 9 comments

image

I was stupidly waiting for an ssh process to run in background for an unknown need of DevPod and thought it didn't worked.

Maybe we could add Green color for those kind of steps when user action is needed?

vesperrin avatar Sep 22 '23 13:09 vesperrin

Hey @kmarilleau, thanks for opening the issue. We can definitely do a better job of letting you know the command succeeded in the UI, wouldn't change the cli output for this though

pascalbreuninger avatar Sep 25 '23 05:09 pascalbreuninger

@pascalbreuninger I would like to work on this issue, so we need to change colour of something to show that command has run successfully in desktop UI right?

s-vamshi avatar Oct 08 '23 01:10 s-vamshi

@s-vamshi, that'd be cool. We can either show a toast or show a message above the terminal based on the result. We currently handle this in the Actions.tsx file. You can check the action.data.status field for the result

pascalbreuninger avatar Oct 09 '23 08:10 pascalbreuninger

How would it be if we use react toastify? Any thoughts?

s-vamshi avatar Oct 09 '23 09:10 s-vamshi

would prefer to stick to chakra ui because we're using that for other toasts as well :) https://chakra-ui.com/docs/components/toast/usage

pascalbreuninger avatar Oct 09 '23 11:10 pascalbreuninger

Sure will use chakra ui

s-vamshi avatar Oct 09 '23 11:10 s-vamshi

Hello there, @s-vamshi and @pascalbreuninger is this issue being worked upon, I don't see anyone being assigned to this issue,

If no one is working on this issue I would like to give it a try.

0x2f0 avatar Oct 19 '23 03:10 0x2f0

@sarojregmi200 I caught up with some work, I am working on it

s-vamshi avatar Oct 19 '23 03:10 s-vamshi

Great, you are good to go, then I was just wondering if it was not being worked upon. Good luck with the work @s-vamshi

0x2f0 avatar Oct 19 '23 03:10 0x2f0