OSINT-Framework icon indicating copy to clipboard operation
OSINT-Framework copied to clipboard

Update, cleanup of broken and added a few links

Open CancianMatteo opened this issue 1 year ago • 5 comments

Tags have been reordered, from: "children", "name", "type"; to: "name", "type", "children" (more easily readable).

CancianMatteo avatar Jun 27 '24 08:06 CancianMatteo

These are a LOT of changes. It will take me a few days to parse through them all probably. I already pushed a reorder of the json fields. That was a good idea. Diff'ing the adds and removes next.

s0lray avatar Jul 02 '24 06:07 s0lray

These are a LOT of changes. It will take me a few days to parse through them all probably. I already pushed a reorder of the json fields. That was a good idea. Diff'ing the adds and removes next.

Yeah, there are many changes, merging was (and still is) a mess, but I can ensure you that it will worth it, i cleaned up many broken links and formatted better the json. You can freely verify them all...

CancianMatteo avatar Jul 11 '24 16:07 CancianMatteo

I've also already updated my repo manually with the last commits and accepted PR of this repo

CancianMatteo avatar Jul 11 '24 17:07 CancianMatteo

I saw that in a past commit you reordered the tags by yourself, instead of accepting my PR... Would you please make me active contributor of this? I think that I deserve it for the efforts I put on this

CancianMatteo avatar Jul 11 '24 17:07 CancianMatteo

I just did a commit with all the updates you did in the last month, my arf.json is still about 700 rows shorter than yours, this means you have many broken links inside...

CancianMatteo avatar Jul 11 '24 17:07 CancianMatteo

Hi, I spent a lot of time on this PR and was surprised to see it closed without any explanation. That's pretty frustrating, especially given how much I’ve tried to contribute to this project.

In open source, it’s just basic respect to give contributors a reason when you reject their work — it's how we all learn and improve. I’m still open to any constructive criticism or suggestions that could help improve the PR.

I’d appreciate a bit of clarity on this. Thanks, and I hope to hear your (and @s0lray 's) thoughts soon.

CancianMatteo avatar Jun 16 '25 19:06 CancianMatteo