jts icon indicating copy to clipboard operation
jts copied to clipboard

Use Oracle driver from Maven Central

Open yeroc opened this issue 5 years ago • 4 comments

It would simplify things to switch to using the Oracle JDBC driver that has (finally) been published to Maven Central as announced earlier this year at https://medium.com/oracledevs/oracle-jdbc-drivers-on-maven-central-64fcf724d8b.

Maven coordinates:

            <dependency>
                <groupId>com.oracle.ojdbc</groupId>
                <artifactId>ojdbc8</artifactId>
                <version>19.3.0.0</version>
            </dependency>

yeroc avatar Dec 04 '19 04:12 yeroc

As it was hinted at on another issue, the JTS committers aren't presently in a position to make the change and test against a copy of Oracle.

Are you able to contribute that effort? If so, the Contributing guide here (https://github.com/locationtech/jts/blob/master/CONTRIBUTING.md) outlines what you'll need to do in order to submit a PR to address this issue.

jnh5y avatar Dec 04 '19 18:12 jnh5y

I'm happy to open a PR to upgrade the library as this is trivial.

One approach to getting Oracle available for testing may be using a docker container via the TestContainers (https://www.testcontainers.org/modules/databases/oraclexe/) project. However, this requires JUnit 4.x at a minimum. Also, not sure of the maintainers' stance on Docker?

yeroc avatar Dec 04 '19 20:12 yeroc

However, this requires JUnit 4.x at a minimum

FYI you can also use container.start() without having to use JUnit at all

bsideup avatar Dec 05 '19 15:12 bsideup

This is included as part of https://github.com/locationtech/jts/issues/439. Suggest that you close this one

andyjefferson avatar May 23 '21 07:05 andyjefferson