QANet icon indicating copy to clipboard operation
QANet copied to clipboard

mask_logits in layer.py

Open zhaoluffy opened this issue 7 years ago • 1 comments

I think the line "return inputs + mask_value * (1 - mask)" should be "return inputs*mask + mask_value * (1 - mask)"

zhaoluffy avatar Sep 20 '18 03:09 zhaoluffy

You are correct, however, I believe that the difference is very minuscule (probably even smaller than a floating point epsilon) so I saw no point in fixing it.

localminimum avatar Oct 26 '18 12:10 localminimum