FastChat icon indicating copy to clipboard operation
FastChat copied to clipboard

H2O-Danube template & minor fixes

Open psinger opened this issue 1 year ago • 0 comments

Why are these changes needed?

This PR adds a new template for H2O-Danube such as: https://huggingface.co/h2oai/h2o-danube2-1.8b-chat

Additionally, I have updated a few minor things:

  • Changed conv = get_conversation_template(model_id) to conv = get_conversation_template(model_path) to get the correct model template. This will always make sure the template is extracted from the actual model name on HF, and not based on the id one applies locally.
  • Add both input_ids and attention_mask to the model forward which is the clean way of doing it, some models complain otherwise.
  • Updated the .gitignore to not push all jsonl files from generation

psinger avatar Apr 09 '24 14:04 psinger