llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard

Published 20 hours ago • verified publisher icon llvm

[DAG] Added m_AnyBinOp and m_c_AnyBinOp in SDPatternMatch.h

Open Sh0g0-1758 opened this issue 1 year ago • 2 comments

Fixes: #84940

Sh0g0-1758 avatar Mar 24 '24 13:03 Sh0g0-1758

:white_check_mark: With the latest revision this PR passed the Python code formatter.

github-actions[bot] avatar Mar 24 '24 13:03 github-actions[bot]

:white_check_mark: With the latest revision this PR passed the C/C++ code formatter.

github-actions[bot] avatar Mar 24 '24 13:03 github-actions[bot]

The rationale behind going for a separate class here is:

We would need to introduce PredFuncT in the template which would need changes in the template. This would necessitate changes in a large number of functions that use BinaryOpc_match.

Sh0g0-1758 avatar Mar 24 '24 16:03 Sh0g0-1758

Ah really sorry for the delayed response. My OS crashed. Apparently there were some dependency issues with my libstdc++ that happened recently due to which I was unable to run the tests locally. I pushed the changes to get insights from you. I did a clean build of my ubuntu22.04LTS and restored my system applications. Will push the changes today.

Sh0g0-1758 avatar Mar 27 '24 09:03 Sh0g0-1758