enumeratum icon indicating copy to clipboard operation
enumeratum copied to clipboard

allow value constructor param to be any constructor parameter, rather than only the first

Open martijnhoekstra opened this issue 1 year ago • 2 comments
trafficstars

simplify and correct finding the constructor param index for the value param.

As a follow-up, I want to double-check whether we need to require -Yretain-trees.

Some of the boyscouting here is a matter of taste, if it's not to yours, I'm happy to revert.

martijnhoekstra avatar Jun 21 '24 14:06 martijnhoekstra

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.71%. Comparing base (1fbbd04) to head (3aeaa51).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          63       63           
  Lines         511      511           
  Branches       34       34           
=======================================
  Hits          438      438           
  Misses         73       73           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 23 '24 21:06 codecov-commenter

Thanks for this. I will definitely review this once I have some spare time 🙇‍♂️

lloydmeta avatar Jun 29 '24 01:06 lloydmeta