stable-diffusion-webui-forge icon indicating copy to clipboard operation
stable-diffusion-webui-forge copied to clipboard

Published 20 hours ago • verified publisher icon lllyasviel

DoRA support

Open catboxanon opened this issue 1 year ago • 3 comments

Title. Adapted from https://github.com/comfyanonymous/ComfyUI/commit/ae77590b4e0cbab55ac9edb67722092d375fe3ec

Semi-related: I don't think my question I originally asked in https://github.com/lllyasviel/stable-diffusion-webui-forge/discussions/80 was addressed well. Are we planning to sync upstream of both the webui and ComfyUI? Or, only the webui, and to cherry-pick certain updates from ComfyUI such as this one?

catboxanon avatar Mar 27 '24 00:03 catboxanon

I've checked this locally by pulling the request branch and it works fine, will this be merged at any point?

GavChap avatar Apr 10 '24 13:04 GavChap

Hi, this matches ComfyUI but differs from sdwebui. The generated image changes at scale 0. I opened a patch to ComfyUI to try to standardize on sdwebui's approach: https://github.com/comfyanonymous/ComfyUI/pull/3298

ntc-ai avatar Apr 19 '24 06:04 ntc-ai

@catboxanon can you change this pr to dev2 and could @huchenlei merge? seems like main is dead for now

kleineluka avatar May 24 '24 15:05 kleineluka

hi we are going to close PRs before forge's recent major revision if we missed some important PRs, please consider reopen (if that is not already on our todo list

lllyasviel avatar Aug 01 '24 19:08 lllyasviel