tree-view-search-bar icon indicating copy to clipboard operation
tree-view-search-bar copied to clipboard

Search only works on the active directory (open/clicked on)

Open codeitco opened this issue 8 years ago • 7 comments

I recently noticed that I can't search for files inside folders that are collapsed/closed. It will only show files in open folders within tree-view.

Was it always this way or is this a new bug after recent atom core/tree view updates? I think I recall the search plugin filtering files AND directories and the files within ANY directory not too long ago...

codeitco avatar Feb 17 '17 19:02 codeitco

See https://github.com/lixinliang/tree-view-search-bar/issues/3

That's an old problem.

And I haven't fixed it till now.

I think it could not be fixed in normal way🤔, maybe I have to hack it.

Any way, I would figure it out, as soon as possible.

lixinliang avatar Feb 20 '17 08:02 lixinliang

@lixinliang maybe expand all folders when user start typing, and when the field is empty collapse folders to its prev state.

ctf0 avatar Feb 21 '17 23:02 ctf0

In my opinion, I think that if the project folder is including the node_modules, when expanding all folders, there would be too much dom in tree-view...

lixinliang avatar Feb 22 '17 01:02 lixinliang

@lixinliang thanks for your response. I can understand and appreciate how the filter works when looking at an active / open directory, however since the plugin is named "search" I thought it would allow anything typed in the box to show up regardless of whether it is within a closed folder or not.

codeitco avatar Feb 22 '17 04:02 codeitco

@codeitco yep, that's my original idea. However, it's defective right now. And this problem is what I prepare to resolve.

lixinliang avatar Feb 22 '17 05:02 lixinliang

okay, maybe then we can have an extra option under settings to ignore certain folders like node_modules / vendor

ctf0 avatar Feb 22 '17 11:02 ctf0

I want to search especially from node_modules folder. Based on this discussion I noticed I have to first toggle it open. So this would need some kind of settings to enable searching from collapsed folders and exclude certain folders from search

shnigi avatar Jun 13 '18 12:06 shnigi