go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

Kick off the input even if err is nil

Open leszko opened this issue 5 months ago • 1 comments

Otherwise, we may not stop the processing.

leszko avatar Jun 27 '25 08:06 leszko

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.71687%. Comparing base (808f793) to head (0950315). Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_mediaserver.go 0.00000% 5 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3652         +/-   ##
===================================================
+ Coverage   31.70561%   31.71687%   +0.01126%     
===================================================
  Files            156         156                 
  Lines          47244       47243          -1     
===================================================
+ Hits           14979       14984          +5     
+ Misses         31382       31377          -5     
+ Partials         883         882          -1     
Files with missing lines Coverage Δ
server/ai_mediaserver.go 4.73790% <0.00000%> (+0.00477%) :arrow_up:

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 808f793...0950315. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_mediaserver.go 4.73790% <0.00000%> (+0.00477%) :arrow_up:

... and 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 27 '25 08:06 codecov[bot]

Closing the loop here: let's use https://github.com/livepeer/go-livepeer/pull/3652 instead, for fixing the non-nil case.

j0sh avatar Jul 01 '25 16:07 j0sh

Closing the loop here: let's use #3652 instead, for fixing the non-nil case.

https://github.com/livepeer/go-livepeer/pull/3661 you mean right?

mjh1 avatar Jul 02 '25 08:07 mjh1

Closing the loop here: let's use https://github.com/livepeer/go-livepeer/pull/3652 instead, for fixing the non-nil case.

https://github.com/livepeer/go-livepeer/pull/3661 you mean right?

Woops yes, thanks @mjh1

j0sh avatar Jul 02 '25 23:07 j0sh

Ok, thanks @j0sh . Then, closing this one

leszko avatar Jul 14 '25 07:07 leszko