go-livepeer
go-livepeer copied to clipboard
Update payments processed log line
What does this pull request do? Explain your changes. (required) Updates ticket processed log line to report faceValue and winProb used for each ticket since they are the same for all tickets. Total s are used for tickets count and ticketEV.
@stronk-dev let me know if this works or have any feedback.
Specific updates (required)
- Updates summary log line for tickets
Does this pull request close any open issues? #2961
Checklist:
- [ ] Read the contribution guide
- [X ]
makeruns successfully - [ ] All tests in
./test.shpass - [ ] README and other documentation updated
- [ ] Pending changelog updated
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.36459%. Comparing base (
9ed49d8) to head (fa0c520). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2968 +/- ##
===================================================
- Coverage 57.37567% 57.36459% -0.01108%
===================================================
Files 89 89
Lines 15402 15398 -4
===================================================
- Hits 8837 8833 -4
Misses 5973 5973
Partials 592 592
| Files | Coverage Δ | |
|---|---|---|
| core/orchestrator.go | 78.09847% <100.00000%> (-0.14774%) |
:arrow_down: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9ed49d8...fa0c520. Read the comment docs.
| Files | Coverage Δ | |
|---|---|---|
| core/orchestrator.go | 78.09847% <100.00000%> (-0.14774%) |
:arrow_down: |
I like the new logging message. @ad-astra-video and @stronk-dev let me know when you tested it, then I'll review and merge.
@stronk-dev Does this look ok?
@stronk-dev Does this look ok?
Yeah LGTM. Totally forgot about this 😅