go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

change -monitor default to true

Open iameli opened this issue 3 years ago • 2 comments
trafficstars

I'm unclear on why we don't default to including the monitoring metrics. There's not much overhead associated with them and they're useful. I've never heard of another service where Prometheus metrics are off by default. They're only exposed on the already-needs-to-be-secure 7935 port.

Personally, the only place I've ever encountered this flag is helping people understand why they can't query for localhost:7935/metrics and it's because they don't have the monitoring flag enabled.

Any objections?

iameli avatar Sep 05 '22 09:09 iameli

Let's do it - I'll prep a PR and put a message out to the Os in case anyone has a reason to object

thomshutt avatar Sep 05 '22 09:09 thomshutt

Will this cause issues with orchestrators who forget to remove the flag after it's been removed?

stronk-dev avatar Sep 07 '22 15:09 stronk-dev