client-sdk-swift icon indicating copy to clipboard operation
client-sdk-swift copied to clipboard

if participant leave, delegate participantDidDisconnect participant.identity is null

Open wzJun1 opened this issue 1 year ago • 4 comments

Describe the bug If someone leaves and triggers participantDidConnect, then we cannot get identity in RemoteParticipant

SDK Version The latest version

iOS/macOS Version ALL

temporary solution

Participant.swift

func cleanUp(notify _notify: Bool = true) async {
    await unpublishAll(notify: _notify)
    // Reset state
    _state.mutate { $0 = State(sid: $0.sid, identity: $0.identity, name: $0.name) }
    //_state.mutate { $0 = State(sid: "", identity: "", name: "") }
}

wzJun1 avatar Jan 12 '24 06:01 wzJun1

Thanks for the report will fix this

hiroshihorie avatar Jan 12 '24 11:01 hiroshihorie

I think the problem arises again, after participantDidDisconnect is called, identity is null.

wzJun1 avatar Feb 08 '24 04:02 wzJun1

I can confirm this as well

Zrzut ekranu 2024-03-27 o 15 08 23

patryk-sredzinski avatar Mar 27 '24 14:03 patryk-sredzinski

This PR https://github.com/livekit/client-sdk-swift/pull/361 should fix it.

hiroshihorie avatar Mar 27 '24 16:03 hiroshihorie

I have same issue. When the fix will be available?

kwanghyun-two avatar May 07 '24 01:05 kwanghyun-two

@hiroshihorie Can we get this one fixed?

patryk-sredzinski avatar May 28 '24 23:05 patryk-sredzinski

Hello this is fixed in https://github.com/livekit/client-sdk-swift/pull/408 Will be in next release

hiroshihorie avatar Jun 20 '24 20:06 hiroshihorie

This should be fixed now

hiroshihorie avatar Jun 26 '24 05:06 hiroshihorie