client-sdk-js icon indicating copy to clipboard operation
client-sdk-js copied to clipboard

Handle `RTCPeerConnection` error on `replaceTrack`

Open conroywhitney opened this issue 1 year ago • 2 comments

Changes

  • [x] Catch / log InvalidStateError: RTCPeerConnection is closed exception

Repro

  1. In Safari / Firefox (not Chrome / Edge)
  2. After a region change / reconnection
  3. With or without audio processing (Krisp) on
  4. When trying to un-mute with localParticipant.setMicrophoneEnabled
  5. Before: it would raise the InvalidStateError: RTCPeerConnection is closed error and remain muted
  6. After: we can catch the error, but it still doesn't un-mute

Screenshots

Uncaught

Screenshot 2024-11-19 at 1 12 09 PM

Krisp Off

Screenshot 2024-11-19 at 1 04 56 PM

Krisp On

Screenshot 2024-11-19 at 1 02 36 PM

conroywhitney avatar Nov 19 '24 18:11 conroywhitney

⚠️ No Changeset found

Latest commit: 1c7d3154513d6342e7a2e04dbe0b827b63a4abc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 19 '24 18:11 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 19 '24 18:11 CLAassistant