client-sdk-android icon indicating copy to clipboard operation
client-sdk-android copied to clipboard

RTCEngine::sendData does not check send result

Open richardayres opened this issue 2 years ago • 0 comments

https://github.com/livekit/client-sdk-android/blob/6ff3e57f74f13a245a444aeb624c43da0068bfa2/livekit-android-sdk/src/main/java/io/livekit/android/room/RTCEngine.kt#LL465C18-L465C18

When broadcasting data via sendData, the internal call to WebRTC's channel send() does not check the return value. When the call fails, it does so silently, and the calling routine does not receive the expected Exception.

This was experienced when sending copious amounts of data across the data channel, and packets were dropped without indication.

richardayres avatar Jun 15 '23 14:06 richardayres