agents icon indicating copy to clipboard operation
agents copied to clipboard

Converted self._speech_q into an asyncio.Queue to safely manage speech tasks

Open jayeshp19 opened this issue 1 year ago • 2 comments

We're manually managing the self._speech_q list with asyncio.Event()

  • PR : use asyncio.Queue since it's built for handling of asynchronous producer-consumer patterns.

CC: @davidzhao @theomonnom please review it and let me know there's any change

jayeshp19 avatar Oct 18 '24 15:10 jayeshp19

🦋 Changeset detected

Latest commit: 244b34a05d0a2bb75fca4ae39ec43ec144639dc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 18 '24 15:10 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 18 '24 15:10 CLAassistant

I don't think we need that as the behaviour isn't the same

theomonnom avatar Nov 14 '24 01:11 theomonnom