agents icon indicating copy to clipboard operation
agents copied to clipboard

added plugin for smallest.ai tts models

Open hamees-sayed opened this issue 1 year ago • 6 comments
trafficstars

I have added support for the non streaming and non auto regressive model by smallest.ai, following the existing TTS structure in adjacent plugins.

hamees-sayed avatar Oct 10 '24 11:10 hamees-sayed

⚠️ No Changeset found

Latest commit: 19e10a136e8f7c8eba2a1d9d5e0dd8463977a24a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 10 '24 11:10 changeset-bot[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
13 out of 14 committers have signed the CLA.

:white_check_mark: longcw
:white_check_mark: Antonyesk601
:white_check_mark: dan-ince-aai
:white_check_mark: alexshelkov
:white_check_mark: CathyL0
:white_check_mark: yaniv-peretz
:white_check_mark: lucasolinas
:white_check_mark: jayeshp19
:white_check_mark: JohnBurtt10-bot
:white_check_mark: hamees-sayed
:white_check_mark: thavidu
:white_check_mark: sascotto
:white_check_mark: levity
:x: mfernandez-gladia
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 10 '24 11:10 CLAassistant

Hey, thanks for your PR, do you think we could get an API key so we can add this new TTS to our tests?

theomonnom avatar Oct 14 '24 20:10 theomonnom

Hey @theomonnom you can get the api key from here https://waves.smallest.ai/apikeys

hamees-sayed avatar Oct 15 '24 04:10 hamees-sayed

Hi @theomonnom! Just checking if you had a chance to add smallest's TTS to the tests?

hamees-sayed avatar Oct 25 '24 06:10 hamees-sayed

the error seems to be failing because of missing elevanlabs tts key?

hamees-sayed avatar Oct 26 '24 07:10 hamees-sayed

@hamees-sayed Thank you for your PR. I integrated it in my local fork of livekit but I am getting the following error in the integration of smallest ai TTS. Kindly help.

samples = np.frombuffer(self._initial_buffer, dtype=np.int16) ValueError: buffer size must be a multiple of element size

Note: It was working till day before yesterday.

prashantmetadome avatar Nov 20 '24 09:11 prashantmetadome

@prashantmetadome the new changes should fix it @theomonnom any status on when this could be merged or if I have to make any changes?

hamees-sayed avatar Dec 05 '24 10:12 hamees-sayed

I'll create a ticket internally for it, thanks!

theomonnom avatar Dec 05 '24 10:12 theomonnom

hey @theomonnom can you please approve the workflow, i have fixed the ruff formatting issue

hamees-sayed avatar Dec 05 '24 11:12 hamees-sayed

i am so sorry for pinging you so much @theomonnom but i think now it should do it i have also smallest in readme and workflow

hamees-sayed avatar Dec 05 '24 19:12 hamees-sayed

i am so sorry for pinging you so much @theomonnom but i think now it should do it i have also smallest in readme and workflow

Nice thank you, we'll create a key and add it to our secrets before merging

theomonnom avatar Dec 05 '24 20:12 theomonnom

Hey @theomonnom I have tested the pytest module and github workflow and everything's passing on my end, can you please approve the workflow here :)

hamees-sayed avatar Dec 27 '24 14:12 hamees-sayed

@theomonnom hi any update on this PR?

hamees-sayed avatar Jan 20 '25 10:01 hamees-sayed

@theomonnom the PR has been stale for a while can you please have a look?

hamees-sayed avatar Feb 22 '25 14:02 hamees-sayed