agents icon indicating copy to clipboard operation
agents copied to clipboard

Add AssemblyAI Plugin

Open oconnoob opened this issue 1 year ago • 3 comments
trafficstars

Extended from PR 419 - https://github.com/livekit/agents/pull/419

oconnoob avatar Aug 30 '24 18:08 oconnoob

⚠️ No Changeset found

Latest commit: 1572f64033b6075c130dcc8ed60f24efa43d1e5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 30 '24 18:08 changeset-bot[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: cch41
:x: ryan-assemblyai
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 30 '24 18:08 CLAassistant

@ploeber the STT interface requires that the abstract async method _main_task is implemented. Currently _main_task exists as an instance attribute of SpeechStream - I'm not sure how to reconcile this

oconnoob avatar Sep 05 '24 17:09 oconnoob

@ploeber could you test the current changes when you find some time tomorrow?

oconnoob avatar Nov 05 '24 19:11 oconnoob

@ploeber addressed the rest of your comments 🙏

oconnoob avatar Nov 08 '24 16:11 oconnoob

Hey, can @ryan-assemblyai sign the CLA?

theomonnom avatar Nov 12 '24 16:11 theomonnom

@theomonnom signed!

oconnoob avatar Nov 12 '24 20:11 oconnoob

When I click on the CLA it says You have agreed to the CLA for livekit/agents - not sure why it's not updating

oconnoob avatar Nov 12 '24 20:11 oconnoob

@oconnoob ah I think it picked up on your other handle. this is fine IMO.

davidzhao avatar Nov 13 '24 00:11 davidzhao

@oconnoob last thing, could you run:

ruff format . && ruff check --fix .

just to get rid of these formatting warnings

davidzhao avatar Nov 13 '24 00:11 davidzhao

@davidzhao all set!

oconnoob avatar Nov 13 '24 14:11 oconnoob

Thanks @oconnoob!

davidzhao avatar Nov 13 '24 16:11 davidzhao