swift-example icon indicating copy to clipboard operation
swift-example copied to clipboard

Rename asset to lkRed to conform to existing usage

Open speakermagnet opened this issue 2 years ago • 2 comments

Motivation: An asset currently being used in swift-example is the color lkRed. Origin branch included unused asset LKRed.colorset in Assets.xcassets.

Changes made:

  • renamed LKRed.colorset to lkRed-temp.colorset then to lkRed.colorset.
    Simple case changes via renaming did not trigger case-insensitive git therefore 2 commits were needed.
  • Modified my .gitignore to avoid local project specific files. Unclear if these changes should also be part of repo to avoid future conflicts

Please review the changes and let me know if any further modifications are required.

speakermagnet avatar Sep 16 '23 17:09 speakermagnet

Can you resolve the merge conflicts

hiroshihorie avatar Sep 20 '23 07:09 hiroshihorie

I also want to include xcworkspace file

hiroshihorie avatar Sep 20 '23 07:09 hiroshihorie