dlex icon indicating copy to clipboard operation
dlex copied to clipboard

No longer maintained? Happy to jump in πŸ‘‹

Open jamilabreu opened this issue 4 years ago β€’ 17 comments
trafficstars

Hi @liveforeverx! I've been jumping in with Dlex, and noticed you're not as active anymore.

If you could give me a quick overview of how everything works (Confused about Adapters, Protocols, etc), I'm happy to take over. Lmk πŸ˜ƒ

jamilabreu avatar Feb 08 '21 13:02 jamilabreu

Hi, @jamilabreu !

Sorry for late answer.

I'm kind of waiting, what the new direction with GraphQL it will take, so I'm not sure where DGraph goes and where should a driver go at the moment.

But I'm happy to have new maintainers.

You can mail me and we can have hangouts, telegram, skype or any other possibility to discuss everything in person, dive in a code and discuss further changes. What do you think?

liveforeverx avatar Feb 15 '21 18:02 liveforeverx

Hi @liveforeverx and @jamilabreu,

We could open an RFC issue, to gather changes to be made for a version 1 release. Dlex does a lot of things right, is up to date on the current version of Dgraph (to my knowledge), and can be used in production (I have).

For example:

  1. I believe much of the internal API can be simplified to just mutate() and all() / query(), because set() and mutate() do a lot of the same things.
  2. set and delete should be possible in a single query as per Dgraph docs (which we can do with pattern matches).
  3. The typespecs have to be updated.
  4. And I believe Ecto and Dlex can be separated, because Ecto can do the heavy lifting of changesets, and Dlex only needs to do Dlex.set(map) where map is a result of the Ecto.Changeset changes field.

martinthenth avatar Feb 26 '21 01:02 martinthenth

@liveforeverx I'd love a quick tour over zoom or hangouts. I'm free next week starting on Tuesday, any day after 5pm EST. Let me know what works for you!

@martinthenth - you're welcome to join too if you'd like! Happy to see there's interest in keeping Dlex up-to-date πŸ˜ƒ An RFC issue sounds like a good start - want to work on it together?

jamilabreu avatar Feb 26 '21 02:02 jamilabreu

@martinthenth Yes, it is up to date, usually I test against every new version.

  1. The set API should be deprecated. I agree, this was still there on backwards-compatibility reason.
  2. It is already possible (I try to cover all functionality, except for GraphQL atm): https://github.com/liveforeverx/dlex/blob/master/test/dlex_test.exs#L285-L288
  3. Yes, that's true
  4. Completely agree, for version 1.0 - it should. For future developing, I think, it is better to have one place at the moment. For library users of dlex it shouldn't be a problem, as it optionally depends on ecto.

liveforeverx avatar Feb 26 '21 10:02 liveforeverx

@jamilabreu Yes, I can help. :)

@liveforeverx Great! I'm glad the base-API of Dgraph is stable through the different versions. 2: I hadn't seen that, my bad.

martinthenth avatar Feb 26 '21 20:02 martinthenth

@liveforeverx are you free to chat this week? Here's a calendly link with my available times, looking forward to it!

https://calendly.com/abreu-jamil/30

Github would be better with private messages :)

jamilabreu avatar Mar 07 '21 23:03 jamilabreu

Can someone explain the difference between this repo and the one hereβ€”https://github.com/pixelmonster-ou/dlex?

benwoodward avatar Mar 23 '21 21:03 benwoodward

@benwoodward Hi - I'm not sure they're related, looks like a fork?

jamilabreu avatar Mar 27 '21 00:03 jamilabreu

I should have updated here, the author replied with this:

Hi @benwoodward,

The one you linked is the real one. This one just has custom changes I did for https://github.com/pixelmonster-ou/metagraph such as reverse relations, translations etc.

I would suggest you go with @liveforeverx's repo as it's more clean and more up2date.

benwoodward avatar Mar 27 '21 00:03 benwoodward

I'm fine merging my fork into this one if @liveforeverx wants to.

Basically the fork was made so I could add quite custom stuff to model databases such as reverse relationships and mainly translations as this couldn't be handled in a good way that I expected.

@liveforeverx if you are fine with merging it, do you want me to start splitting up the changes into multiple PRs?

jnylen avatar May 25 '21 20:05 jnylen

Really hoping this project will pick up again! I'm learning Elixir and want to use it with Dgraph for a small project πŸ˜„

geoyws avatar Oct 26 '21 09:10 geoyws

πŸ‘‹πŸΌ I've just pushed an updated fork of Dlex with:

  • Updated dependencies
  • Updated api.ex and api.proto
  • Updated fields
  • Deprecated set in favor of mutate
  • Support for redacted fields
  • Updated README with Phoenix instructions

@martinthenth would love some help separating Ecto from Dlex πŸ’―

@jnylen happy to accept your work on translations / reverse relationships

https://github.com/m0dnar/dlex

Excited to get this project going again!

cc: @geoyws @benwoodward @liveforeverx

m0dnar avatar Oct 29 '21 22:10 m0dnar

πŸ‘‹πŸΌ I've just pushed an updated fork of Dlex with:

Fantastic! Are you gonna create a PR or maintain a separate fork?

benwoodward avatar Oct 29 '21 23:10 benwoodward

Fantastic! Are you gonna create a PR or maintain a separate fork?

Separate for now, but I'm not against merging down the road!

m0dnar avatar Oct 30 '21 03:10 m0dnar

I had raised two PRs which are still not merged. In case they are useful, I will be happy to rebase and update, as needed. Keen on contributing going forward as well.

Cheers!

goravbhootra avatar Nov 12 '21 22:11 goravbhootra

@goravbhootra I actually added the changes you suggested in both of your PRs in my fork -- very helpful and appreciated :D Send any others over!

m0dnar avatar Nov 12 '21 23:11 m0dnar

Is this project still maintained? It's still by far the best dgraph client for Elixir, and it'd be a shame for it to fall away.

tjtrabue avatar May 20 '23 14:05 tjtrabue