livebook.dev icon indicating copy to clipboard operation
livebook.dev copied to clipboard

New livebook Teams LP

Open paulo-valim opened this issue 1 year ago • 8 comments
trafficstars

Screenshot 2024-05-08 at 08 33 11

Front-end improvements / fixes

Other tasks before publishing

  • [x] Add video to the hero section (and change the image/thumbnail, and copy on hover)
  • [x] Add video to the "Read data from structured data file formats" section (and change the copy on hover)
  • [ ] Try to reduce font-size of the whole page to match font-size of the Livebook home page

paulo-valim avatar May 08 '24 12:05 paulo-valim

Deploy Preview for livebook-dev ready!

Name Link
Latest commit aa8afbfc6737546da9b7f6cabe8158f82d4e657b
Latest deploy log https://app.netlify.com/sites/livebook-dev/deploys/66acec5b0502b800080167df
Deploy Preview https://deploy-preview-100--livebook-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 08 '24 12:05 netlify[bot]

@paulo-valim found a UI bug where the title "What can you build with Livebook Teams?" goes behind the video when resizing the window:

CleanShot 2024-05-21 at 16 06 01

Here's a video showing the bug: https://share.cleanshot.com/q9PLrLM4

hugobarauna avatar May 21 '24 19:05 hugobarauna

@paulo-valim we need to review/change the resolution of the images.

For example, this is a screenshot (in my MacBook screen) of the beginning of the "Build with Elixir" section:

CleanShot 2024-05-21 at 16 32 59@2x

Look at the resolution of the images, they don't feel sharp.

Now look at the screenshot of that part inside Figma:

CleanShot 2024-05-21 at 16 33 31@2x

The images feel sharp.

Please review the images (maybe need to export them again from Figma).

Also, after exporting the image, reduce the file size using a tool like this: https://tinypng.com/ (that's the one I use manually).

hugobarauna avatar May 21 '24 19:05 hugobarauna

Please review the images (maybe need to export them again from Figma).

Since these are designed by hand, I think we can export them as SVG :)

jonatanklosko avatar May 22 '24 06:05 jonatanklosko

@paulo-valim found another improvement task.

  • when the visitor clicks the play button of a video (either the main one or the one in the bottom)
  • and the visitors starts to play the video
  • after the visitor closes the modal
  • the video continues to be played in the background
  • but the video should stop playing

Here's a video showing the problem: https://share.cleanshot.com/NK0ysb22

hugobarauna avatar May 23 '24 20:05 hugobarauna

@paulo-valim found another improvement task.

  • when the visitor clicks the play button of a video (either the main one or the one in the bottom)
  • and the visitors starts to play the video
  • after the visitor closes the modal
  • the video continues to be played in the background
  • but the video should stop playing

Here's a video showing the problem: https://share.cleanshot.com/NK0ysb22

@hugobarauna, I was checking how to do that, and the fix will depend on the video player we use. Will it be on YT, or do you plan to use another player?

paulo-valim avatar May 23 '24 22:05 paulo-valim

@paulo-valim found another improvement task.

  • when the visitor clicks the play button of a video (either the main one or the one in the bottom)
  • and the visitors starts to play the video
  • after the visitor closes the modal
  • the video continues to be played in the background
  • but the video should stop playing

Here's a video showing the problem: https://share.cleanshot.com/NK0ysb22

@hugobarauna, I was checking how to do that, and the fix will depend on the video player we use. Will it be on YT, or do you plan to use another player?

@paulo-valim we’ll use youtube. 👍🏻

hugobarauna avatar May 23 '24 23:05 hugobarauna

@josevalim just added the video about deploying with teams.

I think this is ready to be merged and deployed.

Should we move forward?

hugobarauna avatar Jul 09 '24 19:07 hugobarauna