Divy
Divy
There are actionable items in my previous comment that you can try out and send a PR. This is not a priority for the core team at the moment.
Chrome has been actively working on a prototype implementation: https://bugs.chromium.org/p/chromium/issues/detail?id=1273291. Last activitiy from 2 days ago
Thanks for the report! This was fixed in the latest release (1.36.1). There was a race condition in the recv buffer. I'm going around closing issues related to this but...
Yes its that one (https://github.com/denoland/fastwebsockets/commit/93d8aff85020fc95f8a654a97497ddfcd8822990) and relavant commit in Deno: https://github.com/denoland/deno/commit/91dc6fa5f11f5621c21397c783ee899bfd9657ef
This should be fixed with the switch from tungstenite to fastwebsockets and JS rewrite. Closing.
Fixed by https://github.com/denoland/deno/pull/16173
Ran the microbenchmarks again and i see no difference. I'd prefer to stay to the default unless there is a clear perf improvement. Thank you for the PR!
Cannot reproduce on macOS either.
It seems https://github.com/denoland/deno/commit/e85ca8be0dafdab28e6283aed64c8ee0eb3a338d caused ~47+ wakeups before a test completes, this means the CPU usage spiked to 100% and it was continously waking up the Rust future that gets the...
main: ``` running 4 tests test converter_object ... bench: 118,463 ns/iter (+/- 110,683) test converter_undefined ... bench: 21,224 ns/iter (+/- 2,585) test handwritten_baseline_object ... bench: 3,489 ns/iter (+/- 148) test...