litmus icon indicating copy to clipboard operation
litmus copied to clipboard

(chaos-exporter): Add Unit Test Cases for file chaos-exporter

Open Sanjay1611 opened this issue 6 years ago • 3 comments

UNIT TEST

What happened:

  • Write the unit-test

What you expected to happen:

  • Write the unit test cases for the chaos-exporter repo

Anything else we need to know?:

  • Issue related to Repository: https://github.com/litmuschaos/chaos-exporter
  • Reference:- https://github.com/litmuschaos/chaos-operator/blob/master/pkg/controller/chaosengine/chaosengine_controller_test.go

Sanjay1611 avatar Sep 30 '19 10:09 Sanjay1611

Does this file exist? I don't see it in chaos-exporter/pkg

dedifferentiator avatar Oct 07 '19 06:10 dedifferentiator

@debojitkakoti It's moved to controller/scrape.go

chandankumar4 avatar Oct 16 '19 06:10 chandankumar4

UNIT TEST

What happened:

  • Write the unit-test

What you expected to happen:

  • Write the unit test cases for the chaos-exporter repo

Anything else we need to know?:

  • Issue related to Repository: https://github.com/litmuschaos/chaos-exporter
  • Reference:- https://github.com/litmuschaos/chaos-operator/blob/master/pkg/controller/chaosengine/chaosengine_controller_test.go

Hello @Sanjay1611 I was going through this issue can you tell me which packages need unit test coverage here or do I need to add unit tests in all packages that have no unit tests present in -https://github.com/litmuschaos/chaos-exporter

jignyasamishra avatar Jan 08 '24 15:01 jignyasamishra

@ispeakc0de have we resolved this issue?

prithvi1307 avatar Feb 26 '24 11:02 prithvi1307

Exporter tests have been added by @Nageshbansal as part of this PR: https://github.com/litmuschaos/chaos-exporter/pull/138. More tests will be added as we go/based on changes made.

ksatchit avatar Mar 07 '24 06:03 ksatchit