litmus icon indicating copy to clipboard operation
litmus copied to clipboard

[Proposal] : Multiple Owner Feature architecture.

Open aryan-bhokare opened this issue 1 year ago • 4 comments
trafficstars

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the commit for DCO to be passed.
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

aryan-bhokare avatar Mar 14 '24 13:03 aryan-bhokare

And is there any db schema changes?

namkyu1999 avatar Mar 14 '24 13:03 namkyu1999

And is there any db schema changes?

yes there's only change in the structure of owner.

type Owner struct {
	UserID   string `bson:"user_id" json:"userID"`
	Username string `bson:"username" json:"username"`
	Invitation    Invitation `bson:"invitation" json:"invitation"`
	JoinedAt      int64      `bson:"joined_at" json:"joinedAt"`
	DeactivatedAt *int64     `bson:"deactivated_at,omitempty" json:"deactivatedAt,omitempty"`
}

aryan-bhokare avatar Mar 14 '24 14:03 aryan-bhokare

Thanks, @aryan-bhokare. Is there a way to extend your proposal to allow only certain users to create projects? I am also wondering why we need to create a project on admin login? Can we make project creation an explicit action?

smitthakkar96 avatar Mar 14 '24 14:03 smitthakkar96

Thanks, @aryan-bhokare. Is there a way to extend your proposal to allow only certain users to create projects? I am also wondering why we need to create a project on admin login? Can we make project creation an explicit action?

Surely we will have to discuss about that. But we will be giving support for deleting the default project which is created on first login.

aryan-bhokare avatar Mar 14 '24 15:03 aryan-bhokare