litmus icon indicating copy to clipboard operation
litmus copied to clipboard

Refactos: GraphQL Server to Remove unused RBAC's

Open RipulHandoo opened this issue 2 years ago • 3 comments

Proposed changes

Removed deprecated and unused RBACs:

  • Checked for the Deprecated/Unused RBAC in roles.go.
  • Deleted RBAC definition for SyncHub

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the commit for DCO to be passed.
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

This PR solve issue https://github.com/litmuschaos/litmus/issues/4120, by removing the unused RBAC's

RipulHandoo avatar Nov 07 '23 13:11 RipulHandoo

LGTM 🚀

SohamRatnaparkhi avatar Nov 07 '23 13:11 SohamRatnaparkhi

Hey @RipulHandoo , Can you check build-pipeline / docker-build-graphql-server (pull_request) ?

namkyu1999 avatar Nov 11 '23 03:11 namkyu1999

Hey @RipulHandoo , Can you check build-pipeline / docker-build-graphql-server (pull_request) ?

@namkyu1999 PTAL!

RipulHandoo avatar Nov 18 '23 14:11 RipulHandoo