litmus-helm
litmus-helm copied to clipboard
litmuschaos
Use Existing Secret in litmus-agent values.yaml
What this PR does / why we need it:
The existing chart may force a user to put a password in source-control. This encourages bad security practices. This fix allows a user to specify a custom secret that can be used instead of the default template.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
- fixes #311
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [x] DCO signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
@flockoftanks Hi. Thanks for your PR. Please, take a look into our Contributing guide.
From what I can observe you need to do the following:
- generate readme documentation with helm-docs (I also left a comment about format)
- check if default configuration fails to install
@flockoftanks Hi. Thanks for your PR. Please, take a look into our Contributing guide.
From what I can observe you need to do the following:
- generate readme documentation with helm-docs (I also left a comment about format)
- check if default configuration fails to install
Any idea what's causing the install to fail? I'm not familiar enough with litmus-agent, but I don't see any useful error messages in the log.
@ispeakc0de hi. can you help here? it gives the same error when I install chart with default values locally.
k logs -f install-litmus-agent-8cmfr
invalid character '<' looking for beginning of value
@ispeakc0de hi. can you help here? it gives the same error when I install chart with default values locally.
k logs -f install-litmus-agent-8cmfr invalid character '<' looking for beginning of value
I think I may have an idea - this chart shouldn't be deployed during our CI. I will fix within the next few days.
@ispeakc0de hi. can you help here? it gives the same error when I install chart with default values locally.
k logs -f install-litmus-agent-8cmfr invalid character '<' looking for beginning of valueI think I may have an idea - this chart shouldn't be deployed during our CI. I will fix within the next few days.
Is this with respect to the added parameter of external secret in litmus-agent?
@ispeakc0de hi. can you help here? it gives the same error when I install chart with default values locally.
k logs -f install-litmus-agent-8cmfr invalid character '<' looking for beginning of valueI think I may have an idea - this chart shouldn't be deployed during our CI. I will fix within the next few days.
Is this with respect to the added parameter of external secret in litmus-agent?
nope. it's just with default values. I think that the problem here is that this chart requires litmus to be installed. Therefore it's not suitable for independent tests. I'm going to exclude it.
So, to clarify, am I waiting for something to change in the master branch that I will merge into this to fix the build?
Thanks for your help so far everyone!
@flockoftanks @Shashankreddy6 hey! I submitted PR: https://github.com/litmuschaos/litmus-helm/pull/314, waiting for approval.
@flockoftanks I made a fix in the main branch. Please, squash your commits, sign it and we will be able to merge it. Thanks!
Not sure how to signoff on your commits that I synced to my branch. When I merged it said I didn't pass TCO checks because your most recent commits in my commit history weren't signed by me.
Following the directions in the "learn more" link and force pushing those signoffs, I think I got some of YOUR commits credit to me. Let me know if I need to change something.
Hello, I would to be interested by this PR (I can aslo work on it if needed). @flockoftanks Are you still working on this PR ?
Hi @flockoftanks , Feel free to close it and open a different one, If that makes things easier for you?
@uditgaurav maybe two weeks is a short delay but it seems the work has stopped on this PR (I'm not saying this negatively, we all have our own life). Would you accept a new PR from someone else? I may have some time for this next week but I don't want to supersede @flockoftanks work if that's not OK.
So, I hope this is not a problem but I opened a PR which reworks the current one and adds the ability to use an existing ConfigMap in addition to an existing Secret.
Hi @flockoftanks Closing this PR due to inactivity and also there is one PR merged by @sambonbonne for same changes. Feel free to open this PR again if there are any further changes.
