lit-element-starter-ts
lit-element-starter-ts copied to clipboard
Include build-script to make use of rollup config
As there already is a rollup.config.js included in this project I expected that there would be a build-script too which makes use of this file. So far rollup is only used for the docs:build and checksize task. Including this new script would help beginners to simplify using the component later on. Throughout the docs roolup is mentioned first when talking about building your component so I think it's fair to include a step to build the component. An alternative would be to also include a webpack config and also step for that but I'd argument for rollup to keep the starter project simple
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!