lit-element-starter-ts icon indicating copy to clipboard operation
lit-element-starter-ts copied to clipboard

Include build-script to make use of rollup config

Open TonySpegel opened this issue 4 years ago • 2 comments
trafficstars

As there already is a rollup.config.js included in this project I expected that there would be a build-script too which makes use of this file. So far rollup is only used for the docs:build and checksize task. Including this new script would help beginners to simplify using the component later on. Throughout the docs roolup is mentioned first when talking about building your component so I think it's fair to include a step to build the component. An alternative would be to also include a webpack config and also step for that but I'd argument for rollup to keep the starter project simple

TonySpegel avatar Jun 08 '21 13:06 TonySpegel

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jun 08 '21 13:06 google-cla[bot]

@googlebot I signed it!

TonySpegel avatar Jun 08 '21 13:06 TonySpegel