de.setf.wilbur icon indicating copy to clipboard operation
de.setf.wilbur copied to clipboard

Updated to build with Lispworks 7

Open rwiker opened this issue 8 years ago • 8 comments

This small set of changes makes it possible to build with lw7, and does not seem to affect building with sbcl and ccl.

rwiker avatar Jun 07 '17 19:06 rwiker

why does lispworks require those compile-time conditionalizations?

lisp avatar Jun 07 '17 22:06 lisp

On 8 Jun 2017, at 00:42 , james anderson [email protected] wrote:

why does lispworks require those compile-time conditionalizations?

Good question… without the eval-when constructs, I'm getting error messages for defequal constructs where the value is constructed via a macro (e.g, rdf-uri, whitespace-char-p). This might be a bug in Lispworks, or it could be a problem with defequal (which looks good to me).

I'll do a little more digging and see if I can figure this one out; I'll get back to you when/if I know what's happening.

rwiker avatar Jun 09 '17 06:06 rwiker

i would need specific examples in order to offer any insight into what may be happening...

lisp avatar Jun 09 '17 07:06 lisp

On 9 Jun 2017, at 09:29 , james anderson [email protected] wrote:

i would need specific examples in order to offer any insight into what may be happening...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lisp/de.setf.wilbur/pull/8#issuecomment-307317063, or mute the thread https://github.com/notifications/unsubscribe-auth/ABA4OjM4V5Awrx5Tx3Bw0pQmAiVBp96xks5sCPRBgaJpZM4NzNMD.

ok… without the eval-when forms, I get

CL-USER 1 > (ql:quickload :wilbur) ; "wilbur:base;" = /Users/raw/quicklisp/local-projects/de.setf.wilbur/ To load "wilbur": Load 1 ASDF system: wilbur ; Loading "wilbur" [package wilbur].

**++++ Error between functions: Undefined operator RDF-URI in form (RDF-URI "ID").

… etc

This indicates that the macro rdf-uri, defined earlier in the file, is somehow not accessible when the compiler sees the form

(defequal -rdf-id-uri- (rdf-uri "ID"))

Wrapping the macro definition for rdf-uri in an eval-when gets rid of the errors in defequal forms that use rdf-uri.

rwiker avatar Jun 09 '17 11:06 rwiker

if i follow the example, the problem reduces to the passage in the attached file. correct?

testmacro.txt

lisp avatar Jun 09 '17 19:06 lisp

On 9 Jun 2017, at 21:17 , james anderson [email protected] wrote:

if i follow the example, the problem reduces to the passage in the attached file. correct?

testmacro.txt https://github.com/lisp/de.setf.wilbur/files/1065023/testmacro.txt — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lisp/de.setf.wilbur/pull/8#issuecomment-307476551, or mute the thread https://github.com/notifications/unsubscribe-auth/ABA4OpC-RHbWuktX0vejT-Zxo-y-kcWnks5sCZoxgaJpZM4NzNMD.

Absolutely:

;;; Compiling file /private/tmp/testmacro.lisp ... ;;; Safety = 3, Speed = 1, Space = 1, Float = 1, Interruptible = 1 ;;; Compilation speed = 1, Debug = 2, Fixnum safety = 3 ;;; Source level debugging is on ;;; Source file recording is on ;;; Cross referencing is on ; (TOP-LEVEL-FORM 0) ; (TOP-LEVEL-FORM 1) ; DEFEQUAL ; (DEFCONSTANT -RDF-URI-) ; RDF-URI

**++++ Error between functions: Undefined operator RDF-URI in form (RDF-URI "ID"). ;; Processing Cross Reference Information ; *** 1 error detected, no fasl file produced. ;;; Compilation finished with 0 warnings, 1 error, 0 notes.

---- Press Space to continue, or press Return to view errors and warnings ----

rwiker avatar Jun 09 '17 19:06 rwiker

did you make any progress with this. i have no recent lispworks. does the issue appear in their "personal edition"?

lisp avatar Jun 13 '17 21:06 lisp

On 13 Jun 2017, at 23:28 , james anderson [email protected] wrote:

did you make any progress with this. i have no recent lispworks. does the issue appear in their "personal edition"?

I'll take another look. I'm pretty sure that this will also affect Lispworks Personal Edition.

rwiker avatar Jun 14 '17 04:06 rwiker