fast-elasticsearch-vector-scoring icon indicating copy to clipboard operation
fast-elasticsearch-vector-scoring copied to clipboard

Published 20 hours ago • verified publisher icon lior-k

Branches for es older than v6.8 read binary source as double[] - contrary to README

Open thenomadlad opened this issue 5 years ago • 1 comments

Was there a reason the branches for es-6.8 onwards were the only ones updated to parse the embedding field into floats instead of doubles?

I think we should either fix the plugin for all versions to interpret the field as float[], or clarify it in the readme. I have an easy enough patch to update the older version branches.

thenomadlad avatar Jan 22 '20 20:01 thenomadlad

no reason. If you can submit a PR go ahead. I would appreciate the help. Just make sure unit tests pass. Thanks

lior-k avatar Jan 25 '20 19:01 lior-k