heads icon indicating copy to clipboard operation
heads copied to clipboard

Switch from flashrom to flashprog

Open tlaurion opened this issue 1 year ago • 40 comments

Flashrom is unfit for a while:

  • No progress bar, leaving users in the dark, Heads gave up on his homemade progress bar because changes in flashrom verbose output, parsed for Heads to draw output constantly changes. Its not for Heads to maintain this. As of master, users left in the dark while erasing/writing to SPI. not cool
  • Bricking with newer flashrom version for internal flashing for nv41... Probably also buggy with newer platforms. Not sure what's up with flashrom
  • Commits missing in flashrom releases for WP on time of release
  • Getting things merged under flashrom is problematic for a while.

See https://github.com/linuxboot/heads/issues/1546 for more details leading for this work.


Unknows @i-c-o-n:

  • [x] xx20: ~hwseq automatic or still needed on command line?~ yes. Added. ok
  • [x] talos II: linux_mtd working? ok.
  • [x] ~legacy boards: internal flashing on --ifd specified bios region: ok? (deprecating soon legacy boards)~: deprecated, but should work.

Tested with amazing progress bar output: PXL_20240902_002217653.MP.jpg

Needs double flashing: reflashing within Heads to see if flashprog is able to flash again the firmware you had

  • [x] x230 : thanks @tlaurion
  • [x] nv41 : thanks @tlaurion
  • [x] one sandy result
    • [x] t420 (xx20): @alexmaloteaux @natterangell (iGPU) @akfhasodh @doob85 : @natterangell th aks for testing https://github.com/linuxboot/heads/pull/1769#issuecomment-2347346184
    • [x] x220 (xx20): @Thrilleratplay @BlackMaria @srgrint : thanks @srgrint for testing once again https://github.com/linuxboot/heads/pull/1769#issuecomment-2336744150
  • [x] one haswell result
    • [x] t440p: @ThePlexus @srgrint @akunterkontrolle @rbreslow : thanks to @fhvyhjriur https://github.com/linuxboot/heads/pull/1769#issuecomment-2340479889
    • [x] w541 (similar to t440p): @ResendeGHF @gaspar-ilom : Thanks @ResendeGHF https://github.com/linuxboot/heads/pull/1769#issuecomment-2342384968
  • [x] talos-2 for linux_mtd : thanks @tlaurion
  • [x] d16 (should work)
    • [x] kgpe-d16 (AMD fam15h) (dropped in coreboot 4.12): @Tonux599 @zifxify @arhabd : thanks @arhabd https://github.com/linuxboot/heads/pull/1769#issuecomment-2342629103
  • [x] legacy-boards? If no answer, deprecate as part of this PR: deprecated.

Quick test for other boards untested:

  • download master zip artifcat from circleci for board, this pr zip.
  • flash this pr zip
  • flash master zip back. If successful, report success.

tlaurion avatar Aug 31 '24 13:08 tlaurion