contest
contest copied to clipboard
Feature/logfile
Added a flag to define a log file that saves the log seperatly.
at a glance, the test failure doesnt seem related, but just to make sure @9eCyberSec can you run ./run_tests.sh locally and see if it fails in the same way? You should just need docker (+compose) as deps
Locally it just works fine.
i've no idea why github didnt send any notifications for your last message, so sorry about that; i'll pull the branch and see why that test is failing
ok, so i ran this a couple of times over the last 2 weeks and it does fail sometimes with timeout. There have been some fixes for tests in the meantime, could you try to rebase on latest and push? Thanks
Thank you for your answer, i did the rebase. Hope it works now.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
main@4ca8170). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 66.14%
=======================================
Files ? 156
Lines ? 9347
Branches ? 0
=======================================
Hits ? 6183
Misses ? 2498
Partials ? 666
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 50.39% <0.00%> (?) |
|
| integration | 57.31% <0.00%> (?) |
|
| unittests | 47.19% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4ca8170...a7f74b1. Read the comment docs.
cool, the tests run now; just need to signoff for the DCO
seems this didnt get any updates since last year; i'll comandeer later on and merge