contest icon indicating copy to clipboard operation
contest copied to clipboard

Feature/logfile

Open 9eCyberSec opened this issue 4 years ago • 8 comments

Added a flag to define a log file that saves the log seperatly.

9eCyberSec avatar Oct 11 '21 11:10 9eCyberSec

at a glance, the test failure doesnt seem related, but just to make sure @9eCyberSec can you run ./run_tests.sh locally and see if it fails in the same way? You should just need docker (+compose) as deps

mimir-d avatar Oct 21 '21 17:10 mimir-d

Locally it just works fine.

9eCyberSec avatar Oct 26 '21 06:10 9eCyberSec

i've no idea why github didnt send any notifications for your last message, so sorry about that; i'll pull the branch and see why that test is failing

mimir-d avatar Nov 08 '21 16:11 mimir-d

ok, so i ran this a couple of times over the last 2 weeks and it does fail sometimes with timeout. There have been some fixes for tests in the meantime, could you try to rebase on latest and push? Thanks

mimir-d avatar Nov 24 '21 23:11 mimir-d

Thank you for your answer, i did the rebase. Hope it works now.

llogen avatar Nov 29 '21 08:11 llogen

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4ca8170). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   66.14%           
=======================================
  Files           ?      156           
  Lines           ?     9347           
  Branches        ?        0           
=======================================
  Hits            ?     6183           
  Misses          ?     2498           
  Partials        ?      666           
Flag Coverage Δ
e2e 50.39% <0.00%> (?)
integration 57.31% <0.00%> (?)
unittests 47.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ca8170...a7f74b1. Read the comment docs.

codecov-commenter avatar Nov 30 '21 23:11 codecov-commenter

cool, the tests run now; just need to signoff for the DCO

mimir-d avatar Dec 01 '21 01:12 mimir-d

seems this didnt get any updates since last year; i'll comandeer later on and merge

mimir-d avatar Aug 08 '22 22:08 mimir-d