sentry-hipchat
sentry-hipchat copied to clipboard
linovia
Doesn't work anymore with sentry 7.7.0, Fixed now
Doesn't work anymore with sentry 7.7.0, Fixed now
Sentry 7.7.0 is using NotificationPlugin as the parent class for a plugin.
NotifyPlugin won't work anymore, even if you can import it and seems good, it just doesn't work.
This PR will fix this issue.
I create an issue on sentry's repo too: https://github.com/getsentry/sentry/issues/2264
The old names still work. The change is unnecessary. However in case something broke on newer sentries, please report this against sentry master.
BUT, I agree this change should happen since it's using an older API. I'm just not sure why you're experiencing an issue with it and we don't. :(
@mattrobenolt this change should not land until we have a release for the renamed APIs. Not sure when that happened.
To clarify, this was renamed and set an alias in Sentry 4.7.0 from a quick git blame.
See: https://github.com/getsentry/sentry/commit/aea609c2049073f99f72f57c4ce7a8882573f8d3
So if this were a problem, it should have surfaced a long time ago.
thanks for reply.
I'd like to reproduce this issue and try to figure out what happened tomorrow since it's really late now.
basically I tried to reinstall sentry 7.7.0 and latest sentry-hipchat again and again, it just didn't work.
after checked and compared the source between webhook and this plugin, I found the difference of base class. then I changed its name in site-package folder manually, it just works.
so weird, I will do some research again tomorrow, will keep you updated.
thanks again.
forgot to tell you that if I click the "test configuration" button, it works perfectly. seem like I got the same problem of https://github.com/getsentry/sentry-slack/issues/17
I will still take a look later.
Oh, I wonder if the plugin is erroring somehow sending the notification.
We'd be logging this into the internal Sentry project. (I assume this is your on-premise version).
Is there anything there?
And are you installing sentry-hipchat from a git sha? Or the latest published release to pypi? The pypi version would be woefully out of date.