linode-blockstorage-csi-driver icon indicating copy to clipboard operation
linode-blockstorage-csi-driver copied to clipboard

[Clean Up] - NodeStageVolume, NodeUnStageVolume, Adding golangci lint to GHA, and various small cleans

Open komer3 opened this issue 1 year ago • 2 comments

General:

  • [ ] Have you removed all sensitive information, including but not limited to access keys and passwords?
  • [ ] Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue

komer3 avatar Jul 17 '24 16:07 komer3

Codecov Report

Attention: Patch coverage is 63.80952% with 152 lines in your changes missing coverage. Please review.

Project coverage is 37.16%. Comparing base (cad2ac1) to head (ea43ccc).

Files Patch % Lines
mocks/mock_nodeserver.go 48.03% 119 Missing :warning:
internal/driver/nodeserver.go 0.00% 17 Missing :warning:
internal/driver/nodeserver_helpers.go 92.79% 7 Missing and 1 partial :warning:
pkg/common/idhelpers.go 0.00% 2 Missing and 2 partials :warning:
main.go 0.00% 3 Missing :warning:
internal/driver/luks.go 96.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #191       +/-   ##
===========================================
+ Coverage   17.43%   37.16%   +19.73%     
===========================================
  Files          19       22        +3     
  Lines        1262     1547      +285     
===========================================
+ Hits          220      575      +355     
+ Misses       1019      938       -81     
- Partials       23       34       +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 17 '24 17:07 codecov[bot]

it looks like you need remove the ./mock directory from code coverage reporting here

eljohnson92 avatar Jul 30 '24 13:07 eljohnson92