linode-blockstorage-csi-driver icon indicating copy to clipboard operation
linode-blockstorage-csi-driver copied to clipboard

Bump versions

Open okokes-akamai opened this issue 1 year ago • 0 comments

  • removed install_terraform from e2e/Makefile
  • bumped Alpine (runner) and Go (builder) in Dockerfile
  • bumped Go in both go.mods
  • updated Go deps in e2es:
    • linodego 1.23 -> 1.25
    • removed redundant github.com/pkg/errors
    • updated k8s.io/api{machinery} to v0.29
    • updated k8s.io/client-go to a mod-based version (v0.29)
    • bumped kmodules.xyz/client-go to v0.29, but I'd like to see this go away at some point (in favour of the slightly clunky client-go/REST stuff)
    • removed github.com/codeskyblue/go-sh, because it was in a function that wasn't used (would've refactored it to os/exec otherwise)
  • updated Go deps in the root module:
    • linodego 1.23 -> 1.25
    • google.golang.org/grpc
    • removed all mod replacements
    • apimachinery -> 0.29
    • did not update github.com/container-storage-interface/spec - it's quite old and I haven't had a chance to introspect it

Code changes:

  • had to change VolumeResourceRequirements from ResourceRequirements
  • all the CRUD operations now accept a context - I used a shared one - a bit icky, let me know if I should instead pass it as an argument

Assorted:

  • Since the xyz client requires Go 1.21.5, I had to bump the go.mod file to the new format - this means this fails on oldstable, which, until mid-Feb, will be Go 1.20 that doesn't support patch versions in go.mod files. I kinda don't want to downgrade at this point.
  • got a bunch of W1219 09:54:35.284718 23462 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
  • I have run the tests, but I have not built the driver to deploy it anywhere

okokes-akamai avatar Dec 19 '23 08:12 okokes-akamai