linode-blockstorage-csi-driver icon indicating copy to clipboard operation
linode-blockstorage-csi-driver copied to clipboard

Reworking release process removed the generate manifests action commit from the process

Open srust opened this issue 2 years ago • 2 comments

General:

  • [ ] Have you removed all sensitive information, including but not limited to access keys and passwords?
  • [ ] Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Feature Requests:

  • [ ] Have you explained your rationale for why this feature is needed?
  • [ ] Have you offered a proposed implementation/solution?

Bug Reporting

Expected Behavior

Previous release processes generated the release deploy yaml from the base yaml and created a commit for the release-specific yaml.

This generate manifests action was removed and no longer does this.

The release specific yaml is uploaded as an asset, but is not checked in.

As of today, we have a new release, but not a new release specific deployment yaml in the repo.

Removed:

--- a/.github/workflows/generate-manifest.yml
+++ /dev/null
@@ -1,21 +0,0 @@
-name: Release manifests
-on:
-  release:
-    types: [ published ]
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@61b9e3751b92087fd0b06925ba6dd6314e06f089 # pin@master
-      - name: Build manifest
-        run: "./hack/release-yaml.sh ${{ github.event.release.tag_name }}"
-      - name: Commit files
-        run: |
-          git config --local user.email "[email protected]"
-          git config --local user.name "GitHub Action"
-          git add -- pkg/linode-bs/deploy/releases/linode-blockstorage-csi-driver*\.yaml
-          git commit -m "Update manifests"
-      - name: Push changes
-        uses: ad-m/github-push-action@65392840bda2e774394d5cd38ca33e5918aec2d3 # pin@master
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
releases srust$ ls
linode-blockstorage-csi-driver-v0.0.1.yaml  linode-blockstorage-csi-driver-v0.2.0.yaml
linode-blockstorage-csi-driver-v0.0.2.yaml  linode-blockstorage-csi-driver-v0.2.1.yaml
linode-blockstorage-csi-driver-v0.0.3.yaml  linode-blockstorage-csi-driver-v0.3.0.yaml
linode-blockstorage-csi-driver-v0.1.0.yaml  linode-blockstorage-csi-driver-v0.4.0.yaml
linode-blockstorage-csi-driver-v0.1.2.yaml  linode-blockstorage-csi-driver-v0.4.1.yaml
linode-blockstorage-csi-driver-v0.1.3.yaml  linode-blockstorage-csi-driver-v0.5.0.yaml
linode-blockstorage-csi-driver-v0.1.4.yaml  linode-blockstorage-csi-driver-v0.5.1.yaml
linode-blockstorage-csi-driver-v0.1.5.yaml  linode-blockstorage-csi-driver-v0.5.2.yaml
linode-blockstorage-csi-driver-v0.1.6.yaml  linode-blockstorage-csi-driver-v0.5.3.yaml
linode-blockstorage-csi-driver-v0.1.7.yaml  linode-blockstorage-csi-driver.yaml

Previously as shown each release created a separate deployment.

Actual Behavior

Steps to Reproduce the Problem

Environment Specifications

Screenshots, Code Blocks, and Logs

Additional Notes

Can this be re-instated please?

For general help or discussion, join the Kubernetes Slack team channel #linode. To sign up, use the Kubernetes Slack inviter.

The Linode Community is a great place to get additional support.

cc @luthermonson

srust avatar Dec 04 '23 23:12 srust

This was on purpose, we moved it to a release artifact, this job wasn't working any more

luthermonson avatar Dec 05 '23 04:12 luthermonson

Given @luthermonson's comment, can this issue be closed out?

nesv avatar Jul 11 '24 15:07 nesv