Liger-Kernel icon indicating copy to clipboard operation
Liger-Kernel copied to clipboard

Softcap support in Flce[WIP]

Open troy1729 opened this issue 1 year ago • 2 comments

Summary

Softcap support in FLCE to make it available for Gemma2 #127

Testing Done

  • Hardware Type: <BLANK>
  • [ ] run make test to ensure correctness
  • [ ] run make checkstyle to ensure code style
  • [ ] run make test-convergence to ensure convergence

troy1729 avatar Aug 28 '24 22:08 troy1729

I'm wondering why this pr is not merged?

wizyoung avatar Sep 05 '24 14:09 wizyoung

I found the numerical precision cannot be guarranted in this pr under fp32

wizyoung avatar Sep 06 '24 12:09 wizyoung

This is supported after 0.4.1

ByronHsu avatar Nov 13 '24 01:11 ByronHsu