Steven Giesel

Results 173 comments of Steven Giesel

Don't worry. Nothing urgent and totally understandable. If I can come up with something I let you know. Otherwise we can also wait until the first users report issues and...

Small input from my side as I fiddled around on my MAC: This seems a potential candidate: https://github.com/koenvzeijl/AspNetCore.SassCompiler The problem with LibSassBuilder (cc @ysmoradi) is that it does not support...

Thanks for the input @ysmoradi. Please don't consider this with urgency. Seems like not that many people have that problem and for my part, I do have a spare windows...

I guess it is more a question of highlighting in the documentation then. Just making the user aware that `FakeNavigationManager.History.Last().HistoryEntryState` holds the information passed to `NavigateToLogin`.

Fair point, we can offer a method to deserialise the object to `InteractiveRequestOptions`. I quickly checked the code and basically we could more or less copy paste the current logic...

I had a quick look and propose the following solution. We extend our `FakeNavigationManager` with one method: ```csharp public bool TryGetInteractiveRequestOptions(out InteractiveRequestOptions? requestOptions) { requestOptions = null; if (string.IsNullOrEmpty(Options.HistoryEntryState)) return...

Ah I thought I finalize the proposal. Well we could add something like `FromJson` on top, but to be honest, it seems more error prone than my proposal. Especially because...

> I would like to have this sorted before we push a new release. Of course, if the problem also exists in the currently released version, then there is no...

For sure I had failing tests on my `NavigationLock` PR on the windows runner. But yes locally I also get green tests. To rule out that .net 7 rc1 fixed...

> Are you using the repeating tests i posted above? Yes did use your attached code snippet and let it run against .net6 and .net7.