line-fido2-server icon indicating copy to clipboard operation
line-fido2-server copied to clipboard

Make checkOrigin also available under non-android/ios scenario

Open tymaoa2 opened this issue 10 months ago • 1 comments
trafficstars

Hi, it is sweet to see that checkOrigin func implemented, which help user setup multiple effective origins, but only limit to android/ios devices. (The code looks like this, if i do not misunderstand it) code link

Is it possible to remove the limitation that only ios/android devices can be applied? For two reasons:

  1. User have devices other than ios/android.
  2. For web scenario, there also have multi-origins setup needed, like a web services under mutiple ccTLDs: doc link

Eager to hear your opinion, thank you!

tymaoa2 avatar Jan 24 '25 01:01 tymaoa2

@tymaoa2 , thank you for sharing your opinion.

Additionally, while using the Passkey API on iOS and Android, the origin does not begin with android: or ios:, making it difficult to proceed with the flow outlined below.

https://github.com/line/line-fido2-server/blob/c9b3338f94fc5c1db3f3f2c9637df6aea7536a2a/fido2-core/src/main/java/com/linecorp/line/auth/fido/fido2/server/service/ResponseServiceImpl.java#L150-L162

We are planning to update to the code in the near future.

kimdora avatar Apr 16 '25 04:04 kimdora